Skip to content

fix: show warning when --env.snapshot is provided for debug builds #4736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2019
Merged

fix: show warning when --env.snapshot is provided for debug builds #4736

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b010e00
fix: show warning when --env.snapshot is provided for debug builds
Fatme Jun 18, 2019
1eb3496
chore: fix PR comments
Fatme Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions lib/services/webpack/webpack-compiler-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as path from "path";
import * as child_process from "child_process";
import * as os from "os";
import { EventEmitter } from "events";
import { performanceLog } from "../../common/decorators";
import { hook } from "../../common/helpers";
Expand All @@ -12,7 +13,8 @@ export class WebpackCompilerService extends EventEmitter implements IWebpackComp
private $childProcess: IChildProcess,
public $hooksService: IHooksService,
private $logger: ILogger,
private $pluginsService: IPluginsService
private $pluginsService: IPluginsService,
private $mobileHelper: Mobile.IMobileHelper
) { super(); }

public async compileWithWatch(platformData: IPlatformData, projectData: IProjectData, prepareData: IPrepareData): Promise<any> {
Expand Down Expand Up @@ -103,7 +105,7 @@ export class WebpackCompilerService extends EventEmitter implements IWebpackComp
@hook('prepareJSApp')
private async startWebpackProcess(platformData: IPlatformData, projectData: IProjectData, prepareData: IPrepareData): Promise<child_process.ChildProcess> {
const envData = this.buildEnvData(platformData.platformNameLowerCase, projectData, prepareData);
const envParams = this.buildEnvCommandLineParams(envData, platformData);
const envParams = this.buildEnvCommandLineParams(envData, platformData, prepareData);

await this.$pluginsService.ensureAllDependenciesAreInstalled(projectData);

Expand Down Expand Up @@ -156,13 +158,16 @@ export class WebpackCompilerService extends EventEmitter implements IWebpackComp
return envData;
}

private buildEnvCommandLineParams(envData: any, platformData: IPlatformData) {
private buildEnvCommandLineParams(envData: any, platformData: IPlatformData, prepareData: IPrepareData) {
const envFlagNames = Object.keys(envData);
// const snapshotEnvIndex = envFlagNames.indexOf("snapshot");
// if (snapshotEnvIndex > -1 && !utils.shouldSnapshot(config)) {
// logSnapshotWarningMessage($logger);
// envFlagNames.splice(snapshotEnvIndex, 1);
// }
const snapshotEnvIndex = envFlagNames.indexOf("snapshot");
const shouldSnapshot = prepareData.release && os.type() !== "Windows_NT" && this.$mobileHelper.isAndroidPlatform(platformData.normalizedPlatformName);
if (snapshotEnvIndex > -1 && !shouldSnapshot) {
this.$logger.warn("Stripping the snapshot flag. " +
"Bear in mind that snapshot is only available in release builds and " +
"is NOT available on Windows systems.");
envFlagNames.splice(snapshotEnvIndex, 1);
}

const args: any[] = [];
envFlagNames.map(item => {
Expand Down