Skip to content

Add time(hours, minutes and seconds) to cli version. #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

vhristov5555
Copy link

All other packages in Nativescript(e.g. Runtime, Angular...) have time in their version. We are using the time in the version to determine if we need to run tests. We run tests if the package has been released within the 24 hours period since running the triggering job.

@cla-bot cla-bot bot added the cla: yes label Jun 14, 2019
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new format is 6.0.0-2019-06-14-132351-13405 - merge it in case that's the required one.

@vhristov5555
Copy link
Author

All other packages format is 6.0.0-2019-06-13-112614-01 so this should be right.

@vhristov5555 vhristov5555 merged commit b144430 into master Jun 14, 2019
@vhristov5555 vhristov5555 deleted the vhristovchange_version_to_include_time branch June 14, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants