feat: update supported Node.js versions #4675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update supported Node.js versions according to https://github.com/nodejs/Release - Stop support for Node.js 6 and 7 - CLI will not allow execution of any command when this Node.js is used. - Deprecate support for Node.js 8 and 9 - CLI will print warning on each command when any of those versions is used - Add official support for Node.js 12 - CLI will not print warning for this version as it is officially supported now. Also fix the check of `getNodeWarning` method which was returning warning only the first time when it is called.
|
test cli-smoke |
KristianDD
reviewed
Jun 4, 2019
| } | ||
|
|
||
| return nodeWarn; |
There was a problem hiding this comment.
Maybe you can return a deep copy, so that consumers can't modify the warning. Not a merge blocker.
There was a problem hiding this comment.
I'm not sure about this, so I'll keep it this way for the moment and I'll keep it in mind in case such issue occurs in the future. Thanks for the suggestion.
KristianDD
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update supported Node.js versions according to https://github.com/nodejs/Release
Also fix the check of
getNodeWarningmethod which was returning warning only the first time when it is called.PR Checklist
What is the current behavior?
CLI prints deprecation warning when Node.js 6.x.x or 7.x.x is used.
CLI stops execution when Node.js < 6 is used.
CLI prints warning when Node.js 12 is used.
What is the new behavior?
CLI prints deprecation warning when Node.js 8.x.x or 9.x.x is used.
CLI stops execution when Node.js < 8 is used.
CLI does not print warning when Node.js 12 is used
Implements: