Skip to content

fix: pass correct args when using deprecated logger API #4670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

rosen-vladimirov
Copy link
Contributor

Several logger methods have been deprecated, but their usage had been broken. Fix it until we delete them.
The current problem arises when we pass several args to the logger.out (or any deprecated method) - instead of passing args directly to logger.info, we need to spread them

PR Checklist

What is the current behavior?

tns account command prints incorrect table.

What is the new behavior?

tns account prints correct table.

Fixes/Implements/Closes #[Issue Number].

Several logger methods have been deprecated, but their usage had been broken. Fix it until we delete them.
The current problem arises when we pass several args to the `logger.out` (or any deprecated method).
@rosen-vladimirov rosen-vladimirov added this to the 5.4.1 milestone Jun 3, 2019
@rosen-vladimirov rosen-vladimirov self-assigned this Jun 3, 2019
@cla-bot cla-bot bot added the cla: yes label Jun 3, 2019
@rosen-vladimirov rosen-vladimirov merged commit c226d65 into release Jun 3, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-deprecated-logger-apis branch June 3, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants