fix: incorrect error for non-supported Node.js version #4666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case you are using unsupported Node.js version CLI must show you error that this version is not supported and to inform you which is the supported range. Currently this is not working and CLI shows error for `Unexpected token`. The problem is that CLI has some specific logic to check the Node.js version and the code should be pure ES5 syntax in order to work with old Node.js versions (by default CLI's code is ES6). The current issue is caused by using string interpolation in the mentioned code. Fix the message to fix the problem.
|
test cli-smoke |
KristianDD
approved these changes
May 31, 2019
|
test cli-smoke nativescript-dev-typescript#latest |
|
test cli-smoke nativescript-dev-typescript#latest tns-core-modules#5.4.0 |
1 similar comment
|
test cli-smoke nativescript-dev-typescript#latest tns-core-modules#5.4.0 |
|
test cli-smoke nativescript-dev-typescript#latest tns-core-modules#5.4.0 |
1 similar comment
|
test cli-smoke nativescript-dev-typescript#latest tns-core-modules#5.4.0 |
|
test cli-smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you are using unsupported Node.js version CLI must show you error that this version is not supported and to inform you which is the supported range. Currently this is not working and CLI shows error for
Unexpected token.The problem is that CLI has some specific logic to check the Node.js version and the code should be pure ES5 syntax in order to work with old Node.js versions (by default CLI's code is ES6).
The current issue is caused by using string interpolation in the mentioned code. Fix the message to fix the problem.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes #4665