fix: generated App Store icon has alpha channel #4632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test cli-resources |
rosen-vladimirov
approved these changes
May 22, 2019
| break; | ||
| default: | ||
| throw new Error(`Invalid image generation operation: ${operation}`); | ||
| } | ||
|
|
||
| if (assetItem.rgba === false) { | ||
| image = image.rgba(false); |
There was a problem hiding this comment.
this whole if looks strange, can you please add a comment what's the idea of it
KristianDD
force-pushed
the
kddimitrov/fix-app-store-icon-rgba
branch
from
2b2f64c to
81ca059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently the App Store icon is generated with transparency alpha channel which is not permitted by Apple: for reference Stack Overflow thread.
What is the new behavior?
For this particular image the alpha channel is disabled.
Fixes/Implements/Closes #4584