Skip to content

fix: ensure analytics and cleanup processes are not leaking #4599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2019
Merged

fix: ensure analytics and cleanup processes are not leaking #4599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/detached-processes/cleanup-process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ process.on("message", async (cleanupProcessMessage: ICleanupMessageBase) => {
process.on("disconnect", async () => {
fileLogService.logData({ message: "cleanup-process received process.disconnect event" });
await executeCleanup();
$injector.dispose();
process.exit();
});

fileLogService.logData({ message: `cleanup-process will send ${DetachedProcessMessages.ProcessReadyToReceive} message` });
Expand Down
2 changes: 1 addition & 1 deletion lib/services/analytics/analytics-broker-process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const finishTracking = async (data?: ITrackingInformation) => {
analyticsLoggingService.logData({ message: `analytics-broker-process finish tracking started` });
await trackingQueue;
analyticsLoggingService.logData({ message: `analytics-broker-process tracking finished` });
process.disconnect();
$injector.dispose();
process.exit();
};

Expand Down