fix: fix the order of applying Podfiles #4579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when CLI adds plugin's Podfile, it places its content at the top of the newly generated Podfile. Same happens for the post_install hook of the plugin. The last Podfile that is applied, is the one from App_Resources/iOS, but its content is also placed at the top of the merged Podfile and its post_install action (in case it has such) is executed first. The idea of having Podfile in App_Resources/iOS was to be able to overwrite some settings from plugins Podfiles, for example SWIFT_VERSION. To handle this, append each Podfile at the end of the merged Podfile. Same is valid for the post_install hook coming from a Podfile - it will be appended at end of the merged post_install function.
ghost
added
the
|
test cli-smoke cli-plugin cli-templates cli-build |
|
test cli-templates |
Fatme
approved these changes
May 3, 2019
|
test cli-templates |
3 similar comments
|
test cli-templates |
|
test cli-templates |
|
test cli-templates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when CLI adds plugin's Podfile, it places its content at the top of the newly generated Podfile. Same happens for the post_install hook of the plugin. The last Podfile that is applied, is the one from App_Resources/iOS, but its content is also placed at the top of the merged Podfile and its post_install action (in case it has such) is executed first.
The idea of having Podfile in App_Resources/iOS was to be able to overwrite some settings from plugins Podfiles, for example SWIFT_VERSION.
To handle this, append each Podfile at the end of the merged Podfile. Same is valid for the post_install hook coming from a Podfile - it will be appended at end of the merged post_install function.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes issue #4512