Fix library add ios with spaces in path #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
| @@ -230,7 +230,7 @@ class IOSProjectService implements IPlatformProjectService { | |||
| this.$errors.failWithoutHelp("The bundle at %s does not contain an Info.plist file.", libraryPath); | |||
| } | |||
|
|
|||
| var packageType = this.$childProcess.exec('/usr/libexec/PlistBuddy -c "Print :CFBundlePackageType" ' + infoPlistPath).wait().trim(); | |||
| var packageType = this.$childProcess.exec(util.format('/usr/libexec/PlistBuddy -c "Print :CFBundlePackageType" "%s"', infoPlistPath)).wait().trim(); | |||
There was a problem hiding this comment.
You can use string interpolation here. It makes the code more readable.
jasssonpet
force-pushed
the
jasssonpet/library-add-with-spaces
branch
from
883ae0a to
6c77032
Compare
|
✅ |
|
For this to work, you need to use back quotes (`) |
jasssonpet
force-pushed
the
jasssonpet/library-add-with-spaces
branch
from
6c77032 to
aa3292f
Compare
|
✅ |
|
👍 |
jasssonpet
added a commit
that referenced
this pull request
May 5, 2015
…-spaces Fix library add ios with spaces in path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #459 in the CLI