Kddimitrov/watch app #4568
Merged
Kddimitrov/watch app #4568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
KristianDD
force-pushed
the
kddimitrov/watch-app
branch
from
f1d48d8 to
5b34894
Compare
KristianDD
force-pushed
the
kddimitrov/watch-app
branch
from
5b34894 to
be2ee2a
Compare
|
test cli-smoke |
|
test cli-smoke |
rosen-vladimirov
approved these changes
May 7, 2019
| const addedWatchApp = await this.$iOSWatchAppService.addWatchAppFromPath({ watchAppFolderPath: path.join(resourcesDirectoryPath, platformData.normalizedPlatformName), projectData, platformData, pbxProjPath }); | ||
|
|
||
| if (addedWatchApp) { | ||
| this.$logger.warn("The support for Apple Watch App is currently in Beta. For more information about the current development state and any known issues, please check the relevant GitHub issue: ISSUE LINK"); |
There was a problem hiding this comment.
Don't forget to add the link here
| {name: "PRODUCT_BUNDLE_IDENTIFIER", value: identifier}, | ||
| {name: "SDKROOT", value: "watchos"}, | ||
| {name: "TARGETED_DEVICE_FAMILY", value: IOSDeviceTargets.watchos}, | ||
| {name: "WATCHOS_DEPLOYMENT_TARGET", value: 5.2}, |
There was a problem hiding this comment.
should we hardcode this?
There was a problem hiding this comment.
I agree that its not obvious, but I left a way for the user to override this setting in the watchapp.json and extension.json. The method call here will read the JSON file and set all target build configuration properties listed in the property - the code is here.
For an example how the JSON file will look like you can check point 7 in the related issue description here.
There was a problem hiding this comment.
Thanks for the great explanation and please excuse me for not checking the related issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #4541