Skip to content

feat: deprecate the legacy workflow and recommend the new one #4546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2019

Conversation

DimitarTachev
Copy link
Contributor

@DimitarTachev DimitarTachev commented Apr 18, 2019

These changes are fully deprecating the Legacy Development Workflow and preparing the users for removing the its support in NativeScript 6.0.0.

PR Checklist

What is the current behavior?

We are fully supporting both the legacy prepare (copying the whole app folder and post-processing it with nativescript-dev-typescript, nativescript-dev-sass, etc.) and the webpack approach (using nativescript-dev-webpack and its plugins/loaders).

What is the new behavior?

We are deprecating the legacy workflow as shown on the charts below:

WebpackLegacyWorkflowHandlingDetailed

Related to: #4548

@cla-bot cla-bot bot added the cla: yes label Apr 18, 2019
@ghost ghost assigned DimitarTachev Apr 18, 2019
@ghost ghost added the new PR label Apr 18, 2019
@DimitarTachev DimitarTachev force-pushed the tachev/legacy-workflow-warnings branch from e2492d8 to c5ae8d6 Compare April 18, 2019 14:28
@DimitarTachev DimitarTachev force-pushed the tachev/legacy-workflow-warnings branch from c5ae8d6 to dfbc087 Compare April 19, 2019 05:40
@DimitarTachev DimitarTachev marked this pull request as ready for review April 19, 2019 13:33
@DimitarTachev
Copy link
Contributor Author

test cli-smoke#latest

@DimitarTachev
Copy link
Contributor Author

test cli-smoke

@DimitarTachev DimitarTachev force-pushed the tachev/legacy-workflow-warnings branch from 8bfd41b to f9be51d Compare April 23, 2019 08:26
Copy link
Contributor

@KristianDD KristianDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning looks weird on Windows. Please check it before merge.

@DimitarTachev DimitarTachev merged commit 8b83f91 into master Apr 24, 2019
@ghost ghost removed the new PR label Apr 24, 2019
@DimitarTachev DimitarTachev deleted the tachev/legacy-workflow-warnings branch April 24, 2019 12:51
@elmissouri16
Copy link

@DimitarTachev I didn't work with native script for a year now I installed the latest version and i create with tns create app_name --js and when i run it i got this
"You are using the Legacy Workflow" im using windows any reason for it

@DimitarTachev
Copy link
Contributor Author

@elmissouri16 I suppose you are using the next version of the CLI as this warning is not released in the official (latest) version yet.

You are getting the warning because the official app templates are not released with the new workflow. In order to switch to the recommended workflow before the official release, you can run tns update --workflow in your existing apps.

P.S. Bear in mind that this command is available only in nativescript@next. You could also switch the workflow by manually following the useLegacyWorkflow update described in this blog post .

@elmissouri16
Copy link

@DimitarTachev ok thanks lot I well try this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants