Skip to content

Shows an appropriate message while trying to run the app in a non-project folder #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented Apr 16, 2019

Shows up an appropriate message while trying to run app in non-project directory

PR Checklist

What is the current behavior?

If you try to run app in non-project folder with --path in command without existing folder, you will see exception and you couldn't understand what is the problem.

What is the new behavior?

correct error for non existing folder

Closes #4280

@cla-bot
Copy link

cla-bot bot commented Apr 16, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @jamesgeorge007.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@ghost ghost added the new PR label Apr 16, 2019
@cla-bot cla-bot bot removed the new PR label Apr 16, 2019
@jamesgeorge007 jamesgeorge007 changed the title Towards #4280 Shows an appropriate message while trying to run the app in a non-project folder Apr 16, 2019
@cla-bot cla-bot bot added the cla: yes label Apr 16, 2019
@cla-bot
Copy link

cla-bot bot commented Apr 16, 2019

The cla-bot has been summoned, and re-checked this pull request!

Shows up an appropriate message while trying to run app in non-project directory
@jamesgeorge007 jamesgeorge007 force-pushed the hotfix/show-right-message-cli branch from 1192379 to f8b0948 Compare April 16, 2019 05:23
@ghost ghost added the new PR label Apr 16, 2019
@jamesgeorge007
Copy link
Contributor Author

@Fatme Thoughts?

@Fatme
Copy link
Contributor

Fatme commented Apr 16, 2019

test cli-smoke

@Fatme Fatme merged commit 994fddc into NativeScript:master Apr 16, 2019
@ghost ghost removed the new PR label Apr 16, 2019
@jamesgeorge007 jamesgeorge007 deleted the hotfix/show-right-message-cli branch April 16, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong message if you delete app's folder and run command with --path in it
2 participants