Skip to content

feat: add iCloudContainerEnvironment build option #4526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2019
Merged

feat: add iCloudContainerEnvironment build option #4526

merged 1 commit into from
Apr 11, 2019

Conversation

jzgoda
Copy link
Contributor

@jzgoda jzgoda commented Apr 10, 2019

PR Checklist

What is the current behavior?

Enterprise applications that use iCloud fail to build in 5.x.
(This was not an issue in prior versions.)

The error message is:

error: exportArchive: exportOptionsPlist error for key 'iCloudContainerEnvironment': expected one of {Development, Production}, but no value was provided

What is the new behavior?

Allow the user to pass a new --i-cloud-container-environment option (while doing a --for-device build), that accepts an environment string.

Fixes/Implements/Closes #4374.

@cla-bot cla-bot bot added the cla: yes label Apr 10, 2019
@ghost ghost added the new PR label Apr 10, 2019
@Fatme
Copy link
Contributor

Fatme commented Apr 11, 2019

test cli-smoke

1 similar comment
@Fatme
Copy link
Contributor

Fatme commented Apr 11, 2019

test cli-smoke

@Fatme
Copy link
Contributor

Fatme commented Apr 11, 2019

Hey @jzgoda,

Thank you very much for the contribution!

We think it'll be great to support merging of ExportOptions.plist from App_Resources and from plugins as described here.

We'll more than glad to help you, in case you're interested in implementing this feature.

@Fatme Fatme merged commit 3270ecd into NativeScript:master Apr 11, 2019
@ghost ghost removed the new PR label Apr 11, 2019
@Fatme
Copy link
Contributor

Fatme commented Apr 11, 2019

@jzgoda,

I forgot to mention that if this is your first contribution to NativeScript, you are eligible for our NativeScript First-Time Contribution program. More info can be found here

@jzgoda
Copy link
Contributor Author

jzgoda commented Apr 11, 2019

Thanks for merging, @Fatme!

I'll look into implementing #4528.

@jzgoda jzgoda deleted the add-icloud-container-environment branch September 25, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants