Skip to content

fix: change ksplay to kspreview schema #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2019
Merged

fix: change ksplay to kspreview schema #4496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/services/livesync/playground/preview-qr-code-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class PreviewQrCodeService implements IPreviewQrCodeService {

@exported("previewQrCodeService")
public async getPlaygroundAppQrCode(options?: IPlaygroundAppQrCodeOptions): Promise<IDictionary<IQrCodeImageData>> {
const { projectDir } = options;
const { projectDir } = options || <any>{ };
const result = Object.create(null);

if (!options || !options.platform || this.$mobileHelper.isAndroidPlatform(options.platform)) {
Expand Down
4 changes: 2 additions & 2 deletions lib/services/livesync/playground/preview-schema-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ export class PreviewSchemaService implements IPreviewSchemaService {
subscribeKey: PubnubKeys.SUBSCRIBE_KEY,
default: true
},
"ksplay": {
name: "ksplay",
"kspreview": {
name: "kspreview",
scannerAppId: "com.kinvey.scanner",
scannerAppStoreId: "1263543946",
previewAppId: "com.kinvey.preview",
Expand Down
10 changes: 5 additions & 5 deletions test/services/playground/preview-schema-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ const nsPlaySchema = {
default: true
};

const ksPlaySchema = {
name: 'ksplay',
const ksPreviewSchema = {
name: 'kspreview',
scannerAppId: 'com.kinvey.scanner',
scannerAppStoreId: '1263543946',
previewAppId: 'com.kinvey.preview',
Expand Down Expand Up @@ -56,9 +56,9 @@ describe("PreviewSchemaService", () => {
expectedSchema: nsPlaySchema
},
{
name: "should return ksplay schema when { 'previewAppSchema': 'ksplay' } in nsconfig",
previewAppSchema: "ksplay",
expectedSchema: ksPlaySchema
name: "should return kspreview schema when { 'previewAppSchema': 'kspreview' } in nsconfig",
previewAppSchema: "kspreview",
expectedSchema: ksPreviewSchema
},
{
name: "should throw an error when invalid previewAppSchema is specified in nsconfig",
Expand Down
4 changes: 2 additions & 2 deletions test/services/preview-sdk-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ describe('PreviewSdkService', () => {
},
{
name: "should return the schema from nsconfig",
schemaFromNsConfig: "ksplay",
expectedSchemaName: "ksplay"
schemaFromNsConfig: "kspreview",
expectedSchemaName: "kspreview"
},
{
name: "should return the default schema",
Expand Down