fix: do not wait 60 seconds for debugger port when the app is crashed #4455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
rosen-vladimirov
approved these changes
Mar 20, 2019
DimitarTachev
force-pushed
the
tachev/ios-crashes-livesync
branch
from
2741779 to
41ae672
Compare
|
run ci |
|
test cli-smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
If you LiveSync a crashing app, the CLI will wait 60 seconds for its debug port and log a warning for a manual app start.
What is the new behavior?
If you LiveSync a crashing app, the CLI will start the app and stop looking for its debug port after the crash without logging any warnings.
Related to: #4441