Skip to content

fix: don't change the options in httpRequestCore #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

TsvetanMilanov
Copy link
Contributor

Do not change the options object in the httpRequestCore method of the
$httpClient because if we do, we can't retry correctly the http requests
(e.g. we delete the body property and when we retry the request, we don't have any body to send)

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

Do not change the options object in the httpRequestCore method of the
$httpClient because if we do, we can't retry correctly the http requests
@TsvetanMilanov TsvetanMilanov self-assigned this Mar 18, 2019
@cla-bot cla-bot bot added the cla: yes label Mar 18, 2019
@ghost ghost added the new PR label Mar 18, 2019
@TsvetanMilanov TsvetanMilanov merged commit 964c1cc into release Mar 19, 2019
@TsvetanMilanov TsvetanMilanov deleted the milanov/donot-modify-http-req-opts branch March 19, 2019 08:45
@ghost ghost removed the new PR label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants