fix: get Xcode version correctly #4442
Merged
+4
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
In some cases NativeScript CLI fails on all iOS related commands (build, run, debug, etc.) with error: `NativeScript can only run in Xcode version 6 or greater`. This happens when user has correct Xcode version, i.e. 9 or greater, but the `head` command on their machine does not support `-n` flag. This happens when the `head` command is overwritten by some tool, so the `head` executable is not the original one used by macOS. CLI has some obsolete code to check the Xcode version AFTER it has verified it in the doctorService. Delete this code and use sysInfo's getXcodeVersion, which does not rely on `head` command.
rosen-vladimirov
force-pushed
the
vladimirov/fix-get-xcode-version
branch
from
ee127f4 to
af090bd
Compare
|
test cli-smoke |
KristianDD
approved these changes
Mar 18, 2019
DimitarTachev
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases NativeScript CLI fails on all iOS related commands (build, run, debug, etc.) with error:
NativeScript can only run in Xcode version 6 or greater.This happens when user has correct Xcode version, i.e. 9 or greater, but the
headcommand on their machine does not support-nflag. This happens when theheadcommand is overwritten by some tool, so theheadexecutable is not the original one used by macOS.CLI has some obsolete code to check the Xcode version AFTER it has verified it in the doctorService. Delete this code and use sysInfo's getXcodeVersion, which does not rely on
headcommand.PR Checklist
What is the current behavior?
CLI fails to execute iOS related commands when the
headcommand is not the original one from macOS.What is the new behavior?
CLI is able to execute iOS related commands when the
headcommand is not the original one.Fixes issue #4440