fix: warnings for short imports should be shown correctly #4434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case you have a minified content or just several statements on the same line, we may print you a warning that you have short imports, in cases where you do not have such.
Fix this by splitting the content by new line and by `;` after that. This way, in case you have multiple statements on the same line, we'll separate them and should be able to check them correctly.
Also, ensure `node_modules` of the application are not analyzed.
NOTE: Currently in case you have a multiline string, like:
```
const lodash = require("lodash");console.log(`this is
multiline string
that has require "application" in it
and ends somewhere else`);
```
We'll detect the `that has require "application" in it` line as short import. Add test to show that this is the intended behavior at the moment, as fixing it requires additional complex logic without much benefit.
ghost
added
the
Fatme
approved these changes
Mar 14, 2019
| @@ -132,6 +141,12 @@ export class ProjectDataService implements IProjectDataService { | |||
| } | |||
|
|
|||
| if (fstat.isDirectory()) { | |||
| if (filePath === pathToProjectNodeModules) { | |||
| // we do not want to get the files from node_modules directory of the project. | |||
| // We'll get here only when you have nsconfig.json with appDirectoryPath set to "." | |||
|
test |
1 similar comment
|
test |
|
test package_version#latest |
|
test package_version#latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you have a minified content or just several statements on the same line, we may print you a warning that you have short imports, in cases where you do not have such.
Fix this by splitting the content by new line and by
;after that. This way, in case you have multiple statements on the same line, we'll separate them and should be able to check them correctly.Also, ensure
node_modulesof the application are not analyzed.NOTE: Currently in case you have a multiline string, like:
We'll detect the
that has require "application" in itline as short import. Add test to show that this is the intended behavior at the moment, as fixing it requires additional complex logic without much benefit.PR Checklist
What is the current behavior?
CLI prints warnings for short imports when you have minifed code.
What is the new behavior?
CLI tries to print short imports correctly, even when you have minified code.
Fixes issue #4435