Skip to content

fix: remove the logic for skipCopyTnsModules and skipCopyAppResourcesFiles #4419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Mar 6, 2019

skipCopyTnsModules and skipCopyAppResourcesFiles were introduced in order to satisfy the needs of preview app. As the preview doesn't prepare the project anymore, we don't need this logic.

PR Checklist

What is the current behavior?

There is logic for skipCopyTnsModules and skipCopyAppResourcesFiles.

What is the new behavior?

There is no logic for skipCopyTnsModules and skipCopyAppResourcesFiles.

Introduced here 5986b60

@cla-bot cla-bot bot added the cla: yes label Mar 6, 2019
@ghost ghost assigned Fatme Mar 6, 2019
@ghost ghost added new PR and removed cla: yes labels Mar 6, 2019
@cla-bot cla-bot bot added the cla: yes label Mar 6, 2019
@Fatme Fatme changed the title Fatme/skip copy fix: remove the logic for skipCopyTnsModules and skipCopyAppResourcesFiles Mar 6, 2019
@Fatme
Copy link
Contributor Author

Fatme commented Mar 6, 2019

run ci

5 similar comments
@miroslavaivanova
Copy link
Contributor

run ci

@miroslavaivanova
Copy link
Contributor

run ci

@miroslavaivanova
Copy link
Contributor

run ci

@dtopuzov
Copy link
Contributor

run ci

@dtopuzov
Copy link
Contributor

run ci

@dtopuzov dtopuzov closed this Mar 12, 2019
@dtopuzov dtopuzov reopened this Mar 12, 2019
@ghost ghost removed the new PR label Mar 12, 2019
@ghost ghost assigned dtopuzov Mar 12, 2019
@ghost ghost added the new PR label Mar 12, 2019
@dtopuzov
Copy link
Contributor

test

@Fatme Fatme closed this Mar 19, 2019
@Fatme Fatme reopened this Mar 19, 2019
@ghost ghost added new PR and removed new PR labels Mar 19, 2019
@Fatme Fatme merged commit dea9938 into master Mar 19, 2019
@Fatme Fatme deleted the fatme/skipCopy branch March 19, 2019 08:18
@ghost ghost removed the new PR label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants