fix: avoid leaked lock files for more than 10 seconds #4412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
lockfile
package in order to depend onmodified
, instead ofcreated
date when checking forstale
locks.Replacing the package, we are able to keep smaller
stale
values (e.g. 10 seconds) and avoid losing the lock during long-running operations. In this way, when the CLI process crashes (or is killed with SIGKILL), we won't have leaked lock files for more than 10 seconds.PR Checklist
What is the current behavior?
If the process is killed with SIGKILL (kill -9), the lock files will leak for up to 90 seconds.
What is the new behavior?
If the process is killed with SIGKILL (kill -9), the lock files will leak for 5-10 seconds.