fix: update node-xcode library #4406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
KristianDD
force-pushed
the
kddimitrov/rebase-node-xcode
branch
from
d3cd99b to
4ab889d
Compare
KristianDD
force-pushed
the
kddimitrov/rebase-node-xcode
branch
from
4ab889d to
b2ecf9e
Compare
rosen-vladimirov
approved these changes
Feb 28, 2019
KristianDD
force-pushed
the
kddimitrov/rebase-node-xcode
branch
from
b2ecf9e to
dfe2fc3
Compare
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
filesRelativeToProject is needed to maintain the default behaviour of the library and keep the library tests green.
The ".notadd" file should be added to the PbxFileReference section, but not to the PBXSourcesBuildPhase group.
Related to #4391