chore: improve unit tests #4397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 4 tests marked as `npm support tests`, which are in fact e2e tests - they create project, add dependencies and prepare the project. These tests are executed for around 1 minute. Rewrite them as unit tests, so they take around 20ms now.
There are some extremely slow integration tests for project creation. They mock the prompter and try to validate different use-cases when user enters invalid name and CLI prompts for correct name. However, this is already handled in `project-name-service` tests. So, remove the slow integration tests for project creation and replace them with unit tests that ensure the project creation will fail in case projectNameService fails.
ghost
assigned 
DimitarTachev
approved these changes
Feb 26, 2019
dtopuzov
approved these changes
Feb 26, 2019
Fatme
approved these changes
Feb 26, 2019
| @@ -58,10 +59,11 @@ describe("nodeModulesDependenciesBuilder", () => { | |||
| return path.join(parentDir || pathToProject, constants.NODE_MODULES_FOLDER_NAME, dependencyName); | |||
| }; | |||
|
|
|||
| const getNodeModuleInfoForExpecteDependency = (name: string, depth: number, nativescript?: any, dependencies?: string[]): IDependencyData => { | |||
| const getNodeModuleInfoForExpecteDependency = (dir: string, depth: number, nativescript?: any, dependencies?: string[], name?: string): IDependencyData => { | |||
There was a problem hiding this comment.
getNodeModuleInfoForExpectedDependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: rewrite create project tests
There are some extremely slow integration tests for project creation. They mock the prompter and try to validate different use-cases when user enters invalid name and CLI prompts for correct name.
However, this is already handled in
project-name-servicetests. So, remove the slow integration tests for project creation and replace them with unit tests that ensure the project creation will fail in case projectNameService fails.chore: rewrite npm support tests
There are 4 tests marked as
npm support tests, which are in fact e2e tests - they create project, add dependencies and prepare the project. These tests are executed for around 1 minute.Rewrite them as unit tests, so they take around 20ms now.
PR Checklist
What is the current behavior?
Unit tests are executed for 5-7 minutes
What is the new behavior?
Unit tests are executed for 1:00-1:30 minutes