fix: ensure a single web client connected for debugging #4396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Feb 26, 2019
DimitarTachev
force-pushed
the
tachev/unify-debug-ios
branch
from
130d2cf to
a48af84
Compare
ghost
assigned 
KristianDD
reviewed
Feb 26, 2019
| this.cachedSockets[appId].on("close", () => { | ||
| this.destroyDebugSocket(appId); | ||
| this.cachedSockets[appId].on("close", async () => { | ||
| await this.destroyDebugSocket(appId); |
There was a problem hiding this comment.
This callback will not be awaited and the lock might be released too early. Maybe just resolve a promise outside of the event handler scope after the callback is called and the result of this.destroyDebugSocket(appId) is resolved.
There was a problem hiding this comment.
It will be an infinite wait if we wait for the close event in the create socket method. We are attaching here in order to clean up the cache when the socket is closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
connected to: #4301