fix: set correct versions in plugin's build.gradle #4352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Gradle 3.3.0 (used in tns-android 5.2.0-... ) dependencies checking is stricter and there are some problems in the resolution of the supportLibrary version when building plugins. Issue is raised when the plugin has any of the following: * another compile dependency which is built with `compile` of android support library version that is not the same as the one we are using * plugin defines in its gradle new version of android support library, that is different from the one specified in our build.gradle. To resolve this, set all versions of `com.android.support` libraries to the passed supportVersion or 28.0.0 Also update other tooling versions to latest versions.
miroslavaivanova
approved these changes
Feb 8, 2019
vtrifonov
approved these changes
Feb 8, 2019
KristianDD
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Gradle 3.3.0 (used in tns-android 5.2.0-... ) dependencies checking is stricter and there are some problems in the resolution of the supportLibrary version when building plugins. Issue is raised when the plugin has any of the following:
compileof android support library version that is not the same as the one we are usingTo resolve this, set all versions of
com.android.supportlibraries to the passed supportVersion or 28.0.0Also update other tooling versions to latest versions.
PR Checklist
What is the current behavior?
Unable to build .aar for plugins with rc version of Android runtime.
What is the new behavior?
Plugins can be build.
Fixes issue #4353