fix: incorrect filtering of Android logs by tag #4331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI filters Android logs by PID and by tags. However, in case the PID matches, but we do not find the tag, we may still output the line as we check if it contains the tag anywhere in the content. So, when searching for `JS` tag, we may output the line: ``` 02-01 13:29:23.990 8141 8141 I art : at java.lang.Object com.tns.Runtime.callJSMethod(java.lang.Object, java.lang.String, java.lang.Class, boolean, long, java.lang.Object[]) (Runtime.java:987) ``` Remove this incorrect behavior and rely on the tag filtering.
|
run ci |
DimitarTachev
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI filters Android logs by PID and by tags. However, in case the PID matches, but we do not find the tag, we may still output the line as we check if it contains the tag anywhere in the content.
So, when searching for
JStag, we may output the line:Remove this incorrect behavior and rely on the tag filtering.
PR Checklist
What is the current behavior?
Running
tns run androidwith Android x86 emulator, API Level 24 or 25, shows strange messages in the terminal.What is the new behavior?
Running
tns run androidwith Android x86 emulator, API Level 24 or 25, shows correct messages in the terminal.Fixes issue: #4300