feat: skip postinstall steps in case CLI is not installed globally #4317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitarTachev
approved these changes
Jan 28, 2019
In case the CLI package is not installed globally, probably it is installed as a dependency of a project or as a dependency of other dependency. In this case the postinstall actions have no meaning for the user, as probably CLI will be used as a library. Skip all of the postinstall actions in such case. Remove the execution code of the old `post-install` command and move it to `post-install-cli` command. Add unit tests. Remove a property from staticConfig - it has no meaning to be there, just place it in the postinstall command directly.
Currently the postinstall.js requires helpers and tries to execute some methods of it. However, CLI is not bootstraped and the global variable `_` is not set, so the action fails. Fix the code by adding require to `lodash` in the current file. The other option of fix is to remove the `helpers` require from postinstall script to `post-install-cli` command. However, the current check is if we should execute the postinstall actions - if we move the check to the command, the commands service will still execute the check and prompt the user to allow tracking, which is not a desired behavior.
rosen-vladimirov
force-pushed
the
vladimirov/skip-postinstall-lib
branch
from
da404fd to
3d13b99
Compare
dtopuzov
added a commit
to NativeScript/nativescript-tooling-qa
that referenced
this pull request
Jan 30, 2019
NativeScript/nativescript-cli#4317 remove extra logs when CLI is installed localy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the CLI package is not installed globally, probably it is installed as a dependency of a project or as a dependency of other dependency.
In this case the postinstall actions have no meaning for the user, as probably CLI will be used as a library.
Skip all of the postinstall actions in such case. Remove the execution code of the old
post-installcommand and move it topost-install-clicommand.Add unit tests. Remove a property from staticConfig - it has no meaning to be there, just place it in the postinstall command directly.
Handle case when CLI is installed globally with npm or yarn - in both cases the
npm_config_argvwill be populated with the original command. For example:npm i -g nativescript- thenpm_config_argvwill be:["i", "-g", "nativescript"]yarn global add nativescript- thenpm_config_argvwill be:["global", "add", "nativescript"]PR Checklist
What is the current behavior?
When executing
npm i nativescript, you are prompted to enable autocompletion and all other post install tasks.What is the new behavior?
CLI will ask you to enable autocompletion (and other questions asked on post-install) only when
npm i -g nativescriptoryarn global add nativescriptis used.Implements issue #4323