fix: emit the DEBUGGER_DETACHED event properly #4312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianDD
reviewed
Jan 23, 2019
KristianDD
approved these changes
Jan 23, 2019
…it the DEBUGGER_DETACHED_EVENT just before restarting the app as it was before 5.1.0
DimitarTachev
force-pushed
the
tachev/fix-debugger-detached-event
branch
from
447227d to
6aed7a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
We are not emitting DEBUGGER_DETACHED event at all.
What is the new behavior?
We are emitting the DEBUGGER_DETACHED event just before restarting the app.