fix: use npm view command to get gradle versions from registry in order to fix the problems when private npm registry is configured
#4308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Jan 22, 2019
| const result = await this.$packageManager.view(TNS_ANDROID_RUNTIME_NAME, { "dist-tags": true }); | ||
| runtimeVersion = result.latest; | ||
| } catch (err) { | ||
| this.$logger.trace('error while getting latest android runtime version from view command'); |
There was a problem hiding this comment.
Please print the real error today.
Also, Error should start with capital letter.
| const output = await this.$packageManager.view(`${TNS_ANDROID_RUNTIME_NAME}@${runtimeVersion}`, { gradle: true }); | ||
| runtimeGradleVersions = { gradle: output }; | ||
| } catch (err) { | ||
| const registryData = await this.$packageManager.getRegistryPackageData(TNS_ANDROID_RUNTIME_NAME); |
There was a problem hiding this comment.
Please print the error here
…rder to fix the problems when private npm registry is configured Rel to #4283
Fatme
force-pushed
the
fatme/fix-private-npm-registry
branch
from
399737b to
13b0f4c
Compare
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel to #4283
PR Checklist
What is the current behavior?
{N} CLI does not work when private
npmregistry is configuredWhat is the new behavior?
{N} CLI works when private
npmregistry is configuredFixes/Implements/Closes #[Issue Number].