Skip to content

chore: merge release into master #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 18, 2019
Merged

chore: merge release into master #4298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9cff42c
fix: error is raised when DevTools are closed while sending message
rosen-vladimirov Jan 15, 2019
6bb7f8b
chore: update ios-device-lib to 0.5.0
rosen-vladimirov Jan 15, 2019
19acf2e
fix: Chrome debug messages from iOS Runtime are not parsed correctly
rosen-vladimirov Jan 15, 2019
d50f2e4
Merge pull request #4286 from NativeScript/vladimirov/fix-index-out-o…
rosen-vladimirov Jan 15, 2019
6ebf4ec
fix: trying to stop app on simulator may kill CLI
rosen-vladimirov Jan 16, 2019
93fb3f4
Merge pull request #4288 from NativeScript/vladimirov/fix-killing-cli
rosen-vladimirov Jan 16, 2019
a0a85f8
fix: error may be raised during restart of app on ios Sim
rosen-vladimirov Jan 17, 2019
793881d
Merge pull request #4294 from NativeScript/vladimirov/fix-ios-sim-sto…
rosen-vladimirov Jan 17, 2019
45774c0
docs: update CHANGELOG for 5.1.1
rosen-vladimirov Jan 17, 2019
5149ba1
Merge pull request #4295 from NativeScript/vladimirov/changelog-511
Jan 18, 2019
e190110
Merge branch 'release' into fatme/merge-release-511
Fatme Jan 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,29 @@
NativeScript CLI Changelog
================

5.1.1 (2019, January 17)
==

### Fixed
* [Fixed #4024](https://github.com/NativeScript/nativescript-cli/issues/4024): LiveSync is not working in Preview app when Angular's lazy loading is used
* [Fixed #4197](https://github.com/NativeScript/nativescript-cli/issues/4197): Not able to change IPHONEOS_DEPLOYMENT_TARGET due to CLI overwriting ARCHS and VALID_ARCHS
* [Fixed #4222](https://github.com/NativeScript/nativescript-cli/issues/4222): Sidekick restarts DevTools during debug when change in .xml/.css/.html file is applied
* [Fixed #4218](https://github.com/NativeScript/nativescript-cli/issues/4218): Cannot run app after debug-brk fail
* [Fixed #4228](https://github.com/NativeScript/nativescript-cli/issues/4228): `tns update` command doesn't work with yarn
* [Fixed #4230](https://github.com/NativeScript/nativescript-cli/issues/4230): Debugging with HMR is not working for iOS
* [Fixed #4234](https://github.com/NativeScript/nativescript-cli/issues/4234): Creating project hangs on Windows when yarn is set as package manager
* [Fixed #4236](https://github.com/NativeScript/nativescript-cli/issues/4236): Chrome DevTools(iOS): Debugger does not attach after reloading the page
* [Fixed #4238](https://github.com/NativeScript/nativescript-cli/issues/4238): Fresh project build error on ios
* [Fixed #4251](https://github.com/NativeScript/nativescript-cli/pull/4251): Unhandled promise rejection error from sidekick when livesync to preview app with bundle
* [Fixed #4260](https://github.com/NativeScript/nativescript-cli/issues/4260): CLI crashes when attaching to a non running iOS app
* [Fixed #4261](https://github.com/NativeScript/nativescript-cli/issues/4261): The CLI requires developer disk image not only in debug
* [Fixed #4272](https://github.com/NativeScript/nativescript-cli/issues/4272): Generation of splash screen fails for new templates
* [Fixed #4273](https://github.com/NativeScript/nativescript-cli/issues/4273): `tns debug ios --hmr` If you have two open tabs and close one, breakpoints stop working
* [Fixed #4291](https://github.com/NativeScript/nativescript-cli/issues/4291): Error during debug on iOS: WebSocket is not open: readyState 2 (CLOSING)
* [Fixed #4292](https://github.com/NativeScript/nativescript-cli/issues/4292): Error during debug on iOS: RangeError: Index out of range
* [Fixed #4293](https://github.com/NativeScript/nativescript-cli/issues/4293): Error during debug on iOS: RangeError [ERR_BUFFER_OUT_OF_BOUNDS]


5.1.0 (2018, December 11)
==

Expand Down
11 changes: 8 additions & 3 deletions lib/device-sockets/ios/app-debug-socket-proxy-factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { EventEmitter } from "events";
import { CONNECTION_ERROR_EVENT_NAME } from "../../constants";
import { PacketStream } from "./packet-stream";
import * as net from "net";
import * as ws from "ws";
import temp = require("temp");
import { MessageUnpackStream } from "ios-device-lib";

export class AppDebugSocketProxyFactory extends EventEmitter implements IAppDebugSocketProxyFactory {
private deviceWebServers: IDictionary<ws.Server> = {};
Expand Down Expand Up @@ -134,11 +134,16 @@ export class AppDebugSocketProxyFactory extends EventEmitter implements IAppDebu
const encoding = "utf16le";

const appDebugSocket: net.Socket = (<any>req)["__deviceSocket"];
const packets = new PacketStream();
const packets = new MessageUnpackStream();
appDebugSocket.pipe(packets);

packets.on("data", (buffer: Buffer) => {
webSocket.send(buffer.toString(encoding));
const message = buffer.toString(encoding);
if (webSocket.readyState === webSocket.OPEN) {
webSocket.send(message);
} else {
this.$logger.trace(`Received message ${message}, but unable to send it to webSocket as its state is: ${webSocket.readyState}`);
}
});

webSocket.on("error", err => {
Expand Down
33 changes: 0 additions & 33 deletions lib/device-sockets/ios/packet-stream.ts
View file
Open in desktop

This file was deleted.

22 changes: 11 additions & 11 deletions npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@
"gaze": "1.1.0",
"iconv-lite": "0.4.11",
"inquirer": "6.2.0",
"ios-device-lib": "0.4.15",
"ios-device-lib": "0.5.0",
"ios-mobileprovision-finder": "1.0.10",
"ios-sim-portable": "4.0.6",
"ios-sim-portable": "4.0.8",
"istextorbinary": "2.2.1",
"jimp": "0.2.28",
"lockfile": "1.0.3",
Expand Down