Skip to content

fix: trying to stop app on simulator may kill CLI #4288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

rosen-vladimirov
Copy link
Contributor

In case you use tns run ios --path <path to app> --device <simulator GUID>, CLI will try to stop the application, but may kill CLI instead. The problem is in ios-sim-portable, which incorrectly searches for application PID. Update the package to 4.0.7 where the issue is fixed.
https://github.com/telerik/ios-sim-portable/releases/tag/v4.0.7

PR Checklist

What is the current behavior?

On iOS Simulator:

  • CLI is unable to stop application which has grep in the name, so LiveSync is not working in this case.
  • CLI process is killed when tns run ios --path <path to app> --device <device GUID command is used.

What is the new behavior?

CLI successfully syncs the application.

Fixes issue #4284

In case you use `tns run ios --path <path to app> --device <simulator GUID>`, CLI will try to stop the application, but may kill CLI instead. The problem is in ios-sim-portable, which incorrectly searches for application PID. Update the package to 4.0.7 where the issue is fixed.
@rosen-vladimirov rosen-vladimirov added this to the 5.1.1 milestone Jan 16, 2019
@rosen-vladimirov rosen-vladimirov self-assigned this Jan 16, 2019
@rosen-vladimirov
Copy link
Contributor Author

run ci

1 similar comment
@dtopuzov
Copy link
Contributor

run ci

@rosen-vladimirov rosen-vladimirov merged commit 93fb3f4 into release Jan 16, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-killing-cli branch January 16, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants