fix: fix debug iOS connection issues #4279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need the AttachAvailability response as now we don't need different actions based on the response. We just need to get the debug port which is printed by the AttachRequest and the Runtime is now accepting connections regardless of its state. This also allows us to remove the availability calls from the runtime.
…ssues with multiple device socket connections and attach requests, remove all locks on process exit
DimitarTachev
force-pushed
the
tachev/fix-ios-debug-issues
branch
from
d7a8de8 to
2135c65
Compare
Fatme
approved these changes
Jan 11, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The CLI could become in an invalid state if you open the debug URL and make a few fast refreshes.
What is the new behavior?
The CLI will lock and handle the connections one by one if you open the debug URL and make a few fast refreshes.
Notes:
We also replaced the old 4 iOS attach messages with a single Attach Request. In this way, the Runtime has a single place of attaching and will be able to handle the bug with invalid app state after locking the phone while debugging. related to: NativeScript/ios-jsc#1053