fix: allow Debug + HMR using the public API #4246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitarTachev
force-pushed
the
tachev/fix-debugger-attached-event
branch
from
97e8c47 to
e0a2dbd
Compare
…(allow debug + hmr in sidekick)
DimitarTachev
force-pushed
the
tachev/fix-debugger-attached-event
branch
from
e0a2dbd to
05ce8d0
Compare
Fatme
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The debugger attached event used for reconnecting the debugger in SideKick is fired on each LiveSync.
What is the new behavior?
The debugger attached event used for reconnecting the debugger in SideKick is fired only when the app restarted and the debugger really needs to be reconnected.
related to: #4222