fix: fix debugger attaching after a page reload #4241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitarTachev
force-pushed
the
tachev/fix-ios-debug-proxy
branch
from
60eba82 to
3dd15bc
Compare
DimitarTachev
changed the title
KristianDD
reviewed
Dec 20, 2018
| @@ -152,12 +158,11 @@ export class AppDebugSocketProxyFactory extends EventEmitter implements IAppDebu | |||
| appDebugSocket.on("close", () => { | |||
| this.$logger.info("Backend socket closed!"); | |||
| webSocket.close(); | |||
| server.close(); | |||
There was a problem hiding this comment.
Is the server socket not closed on purpose?
There was a problem hiding this comment.
The server socket is appDebugSocket and this is it's close handler. server is our proxy server and it's not closed in order to stay available for new client connections. Because of this line, the Chrome Dev Tools was not able to reconnect when you try to refresh the page.
|
run ci |
… recreating it each time
DimitarTachev
force-pushed
the
tachev/fix-ios-debug-proxy
branch
from
3dd15bc to
9ae9343
Compare
rosen-vladimirov
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Take a look at the below-mentioned issue.
What is the new behavior?
We are printing the debug proxy port even if we reuse an existing proxy. In this way, VSCode can reattach to the same proxy after a JS file change and we are able to connect and disconnect unlimited number of clients.
Related to #4236