fix: issues when yarn is set as package manager #4233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you've set package manager to `yarn` on Windows, CLI is unable to create a project - it hangs during the operation. The problem is that getting the path to yarn cache returns result with `\n` at the end. This makes the `pacote` package hangs instead of just failing. Fix this by trimming the result of `yarn cache dir` call.
When yarn is set as package manager, `tns update` command fails. The problem is that during command's execution, we try to remove `tns-core-modules-widgets` from the project. When `tns-core-modules-widgets` pacakage is not a dependency of the project (this is the default case as this package is dependency of `tns-core-modules` not a direct dependency of the project), calling `yarn remove` fails. In the same case `npm` does not fail. To resolve the issue, check if `tns-core-modules-widgets` are dependency of the project and uninstall this package only in such case.
Fatme
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: unable to use yarn on Windows
When you've set package manager to
yarnon Windows, CLI is unable to create a project - it hangs during the operation. The problem is that getting the path to yarn cache returns result with\nat the end. This makes thepacotepackage hangs instead of just failing.Fix this by trimming the result of
yarn cache dircall.fix:
tns updatedoes not work when yarn is setWhen yarn is set as package manager,
tns updatecommand fails. The problem is that during command's execution, we try to removetns-core-modules-widgetsfrom the project. Whentns-core-modules-widgetspacakage is not a dependency of the project (this is the default case as this package is dependency oftns-core-modulesnot a direct dependency of the project), callingyarn removefails.In the same case
npmdoes not fail.To resolve the issue, check if
tns-core-modules-widgetsare dependency of the project and uninstall this package only in such case.PR Checklist
What is the current behavior?
When you've set
yarnas package manager, callingtns create myApp --jshangs on Windows.tns updatecommand always fails whenyarnis set as package manager.What is the new behavior?
You can set yarn as package manager and use it on Windows. Also you can use
tns updateon all OSes.Fixes issues: #4228 and #4234