Skip to content

Improve autocompletion #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2015

Conversation

rosen-vladimirov
Copy link
Contributor

Move autocompletion code to a new shell file. In .bash_profile, .bashrc and .zshrc add code that executes this code when we want to enable autocompletion.
Autocomplete is now hierarchical command. The subcommands and their behavior is:

  • autocomplete - checks if autocompletion is enabled. In case it is not, ask the user for confirmation. In case autocompletion is enabled, but it is the old one (where we've written some data to .bash_profile, etc.), silently remove the old code and use the new approach. In case the user chooses to not use autocompletion, call disableAutocCompletion in order to remove all autocompletion code from all shell profiles.
  • autocomplete enable - enables autocompletion in case it is not already enabled.
  • autocomplete disable - disables autocompletion in case it is not already disabled.
  • autocomplete status - prints the current status of autocompletion.

Add help for autocomplete commands.

@ns-bot
Copy link

ns-bot commented Apr 9, 2015

@dtopuzov
Copy link
Contributor

dtopuzov commented Apr 9, 2015

👍

Move autocompletion code to a new shell file. In .bash_profile, .bashrc and .zshrc add code that executes this code when we want to enable autocompletion.
Autocomplete is now hierarchical command. The subcommands and their behavior is:
* `autocomplete` - checks if autocompletion is enabled. In case it is not, ask the user for confirmation. In case autocompletion is enabled, but it is the old one (where we've written some data to .bash_profile, etc.), silently remove the old code and use the new approach. In case the user chooses to not use autocompletion, call disableAutocCompletion in order to remove all autocompletion code from all shell profiles.
* `autocomplete enable` - enables autocompletion in case it is not already enabled.
* `autocomplete disable` - disables autocompletion in case it is not already disabled.
* `autocomplete status` - prints the current status of autocompletion.

Add help for autocomplete commands.
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/merge-autocomplete-fix branch from aae4746 to 3c9bfb1 Compare April 9, 2015 11:46
@ns-bot
Copy link

ns-bot commented Apr 9, 2015

rosen-vladimirov added a commit that referenced this pull request Apr 9, 2015
@rosen-vladimirov rosen-vladimirov merged commit e3c08fa into release Apr 9, 2015
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/merge-autocomplete-fix branch April 9, 2015 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants