fix: project properties are not tracked on every analytics hit #4194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
force-pushed
the
vladimirov/analytics-project-dir
branch
from
88e2b10 to
237bfff
Compare
rosen-vladimirov
changed the title
DimitarTachev
approved these changes
Dec 3, 2018
Fatme
approved these changes
Dec 3, 2018
Currently projectType and isShared properties are tracked only when we send events to Google Analytics and when the caller sends the projectDir to the method. In fact we need to track them(based on the projectDir) for every hit in Google Analytics. To achieve this, use the projectHelper, which tries to determine the projectDir. Track the projectType on every page and event send to Google Analytics.
rosen-vladimirov
force-pushed
the
vladimirov/analytics-project-dir
branch
from
237bfff to
8ab8ed3
Compare
|
run ci |
1 similar comment
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently projectType and isShared properties are tracked only when we send events to Google Analytics and when the caller sends the projectDir to the method. In fact we need to track them(based on the projectDir) for every hit in Google Analytics.
To achieve this, use the projectHelper, which tries to determine the projectDir. Track the projectType on every page and event send to Google Analytics.
PR Checklist
What is the current behavior?
When tracking pageviews in Google Analytics, the respective projectType is not tracked.
Also for some of the events, the projectType is not tracked.
What is the new behavior?
ProjecType is tracked for every hit (when action is executed inside project dir or with
--path)