feat: improve analytics #4153
Merged
feat: improve analytics #4153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitarTachev
approved these changes
Nov 21, 2018
Remove tracking to Eqatec Analytics as we no longer use it.
`xmlhttprequest` package has been used for Eqatec Analytics. We do not need it anymore
…config props Remove `AnalyticsServiceBase` by moving the required code to `AnalyticsService`. Remove obsolete static config props.
Write analytics data to a file passed as `--analyticsLogFile`. The file will contain timestamp when the action is executed and what is the data passed to analytics. Also add some additional logging to the file, so when something fails, it will be easier for diagnostics. In case `--analyticsLogFile` is not passed, information will not be tracked.
rosen-vladimirov
force-pushed
the
vladimirov/remove-eqatec-analytics-2
branch
from
491bd67 to
9ee3ee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
CLI has code for tracking in Google Analytics and in Eqatec Analytics. The second one is not used anymore. Also, there's no way to understand what has been tracked.
What is the new behavior?
Code for tracking in Eqatec Analytics has been removed.
Passing
--analyticsLogFile <path to file>will allow you to check everything that's being tracked to Google Analytics.Additional details
$analyticsServicefrom methods that were used only for Eqatec Analytics trackingFurther improvements:
TODO(Analytics):in the code).analytics-broker-process. This will allow us to removeanalyticsLoggingService(currently it is a separate service as it has to be used fromanalytics-broker-process,AnalyticsBrokerandGoogleAnalyticsProvider).Implements: #4152
Also related to #3827