fix(platform-add): respect nativePlatformStatus property from .nsprepare file when adding the platform #4092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are file when adding the platform As the preview command add only the .js part of the platform, we need to check nativePlatformStatus in order to decide correctly if platform add is necessary
|
run ci |
DimitarTachev
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the preview command add only the .js part of the platform, we need to check nativePlatformStatus in order to decide correctly if platform add is necessary.
PR Checklist
What is the current behavior?
throws an error "Platform already added" but actually no native platform is added.
What is the new behavior?
adds both js and native platform.
rel to:
#4090