-
-
Notifications
You must be signed in to change notification settings - Fork 197
feat(preview): add public API for deviceFound and deviceLost for preview devices #4083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e9e2e50
to
957f0a4
Compare
957f0a4
to
569b498
Compare
75aeedd
to
aeec0ac
Compare
@@ -34,4 +33,11 @@ declare global { | |||
*/ | |||
link: boolean; | |||
} | |||
|
|||
interface IPreviewDevicesService extends EventEmitter { | |||
connectedDevices: Device[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to expose a public setter? We could expose just a getConnectedDevices method.
|
||
interface IPreviewDevicesService extends EventEmitter { | ||
connectedDevices: Device[]; | ||
onDevicesPresence(devices: Device[]): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the context of this service, this should be something like set/update ConnectedDevices.
We want to expose
deviceFound
anddeviceLost
for preview devices as a public api so Sidekick can use them.PR Checklist