Move html styles to common #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all styles of HTML to common lib. Modify replacing in HtmlHelpService to use global match in order to replace all strings in the html. Replace HTML_HELPERS_DIR from StaticConfig with HTML_COMMON_HELPERS_DIR and HTML_CLI_HELPERS_DIR. The idea is to have specific helpers for each CLI and common helpers. Add favicon and logo to docs/helpers dir.
|
✅ |
|
👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Apr 3, 2015
Move html styles to common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all styles of HTML to common lib. Modify replacing in HtmlHelpService to use global match in order to replace all strings in the html. Replace HTML_HELPERS_DIR from StaticConfig with HTML_COMMON_HELPERS_DIR and HTML_CLI_HELPERS_DIR. The idea is to have specific helpers for each CLI and common helpers.
Add favicon and logo to docs/helpers dir.