fix: start log process on tns debug ios --justlaunch command
#4078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
force-pushed
the
fatme/fix-debug-justlaunch
branch
2 times, most recently
from
029c87c to
e4cfe38
Compare
KristianDD
reviewed
Oct 30, 2018
| await this.$iOSDebuggerPortService.attachToDebuggerPortFoundEvent(this.device, debugData, debugOptions); | ||
| await this.startDeviceLogProcess(debugData, debugOptions); |
There was a problem hiding this comment.
I think this should be executed prior to await this.$iOSDebuggerPortService.attachToDebuggerPortFoundEven..., because we depend on the logs to get the port.
Fatme
force-pushed
the
fatme/fix-debug-justlaunch
branch
from
e4cfe38 to
8f6f8e9
Compare
KristianDD
approved these changes
Nov 1, 2018
|
run ci |
Fatme
force-pushed
the
fatme/fix-debug-justlaunch
branch
from
8f6f8e9 to
eadc305
Compare
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently log process is not started when
--justlaunchoption is provided. This leads to error ontns debug ios --justlaunchcommand. Actually we need to start log process in order to get debugger port. On the other side we should not print any logs on the console when--justlaunchoption is provided. So this PR starts log process when--justlaunchoption is specified and doesn't print any logs on the console.PR Checklist
What is the current behavior?
tns debug ios --justlaunchthrows an errorWhat is the new behavior?
tns debug ios --justlaunchdoes not throw an errorRel to: #4076