Skip to content

fix: update natives, so CLI can work on Node.js 11 #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

Upate the natives library, so CLI can work wiht Node.js 11.

PR Checklist

What is the current behavior?

When Node.js 11 is installed, CLI fails to execute any command with error:

Support for Node.js 11.0.0 is not verified. NativeScript CLI might not install or run properly.

ReferenceError: internalBinding is not defined
    at fs.js:25:1
    at req_ (D:\Rosen\Work\nativescript-cli\node_modules\natives\index.js:140:5)
    at Object.req [as require] (D:\Rosen\Work\nativescript-cli\node_modules\natives\index.js:54:10)
    at Object.<anonymous> (D:\Rosen\Work\nativescript-cli\node_modules\fstream\node_modules\graceful-fs\fs.js:1:99)
    at Module._compile (internal/modules/cjs/loader.js:707:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:718:10)
    at Module.load (internal/modules/cjs/loader.js:605:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:544:12)
    at Function.Module._load (internal/modules/cjs/loader.js:536:3)
    at Module.require (internal/modules/cjs/loader.js:643:17)

What is the new behavior?

CLI can execute commands with Node.js 11

Fixes/Implements/Closes #[Issue Number].

Upate the natives library, so CLI can work wiht Node.js 11.
@rosen-vladimirov rosen-vladimirov added this to the 5.0.0 milestone Oct 26, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this Oct 26, 2018
@reinaldorauch
Copy link
Contributor

I'm digging in this too. It seems like the doctor command is demanding the use of natives as seen in here:

 ~/D/P/nativescript-cli    npm list --installed | grep -B10 natives               ter 30 out 2018 14:15:13 -03
[email protected] /home/reinaldo/Documentos/Projetos/nativescript-cli
├── @nativescript/[email protected]
--
│ │ │ └─┬ [email protected]
│ │ │   ├── [email protected]
│ │ │   ├── [email protected]
│ │ │   └── [email protected]
│ │ ├── [email protected]
│ │ └── [email protected]
│ ├── [email protected] deduped
│ └─┬ [email protected]
│   └── [email protected]
├── [email protected]
├─┬ [email protected]
│ ├── [email protected] deduped
│ ├── [email protected]
│ ├── [email protected] deduped
│ ├─┬ [email protected]
│ │ ├─┬ [email protected]
│ │ │ ├── [email protected]
│ │ │ └─┬ [email protected]
│ │ │   └── [email protected]
│ │ ├─┬ [email protected]
│ │ │ ├─┬ [email protected]
│ │ │ │ └── [email protected]

Looks like the use of this old lib unzip by the doctor command is causing this trouble, so i'm working in a solution to rip off this unzip dependency.

@reinaldorauch
Copy link
Contributor

My pull request fixing this: NativeScript/nativescript-doctor#45

@DimitarTachev DimitarTachev modified the milestones: 5.0.0, 5.0.1 Nov 2, 2018
@DimitarTachev DimitarTachev merged commit 8f80a3c into release Nov 5, 2018
@DimitarTachev DimitarTachev deleted the vladimirov/support-node-11 branch November 5, 2018 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants