Skip to content

fix: revert the code share fix in order to avoid getting started issues. #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: revert the code share fix in order to avoid getting started issues. #4037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions lib/services/livesync/playground/preview-app-plugins-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,15 @@ export class PreviewAppPluginsService implements IPreviewAppPluginsService {
public getExternalPlugins(device: Device): string[] {
const devicePlugins = this.getDevicePlugins(device);
const result = _.keys(devicePlugins)
// The core theme links are custom and
// should be handled by webpack during build.
.filter(plugin => plugin !== "nativescript-theme-core");

.filter(plugin => plugin.indexOf("nativescript") !== -1)
// exclude angular and vue related dependencies as they do not contain
// any native code. In this way, we will read them from the bundle
// and improve the app startup time by not reading a lot of
// files from the file system instead. Also, the core theme links
// are custom and should be handled by us build time.
.filter(plugin => !_.includes(["nativescript-angular", "nativescript-vue", "nativescript-intl", "nativescript-theme-core"], plugin));

result.push(...["tns-core-modules", "tns-core-modules-widgets"]);
return result;
}

Expand Down