Skip to content

fix: sync on all platforms when tns run --hmr command is executed #4015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2018
Merged

fix: sync on all platforms when tns run --hmr command is executed #4015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/services/livesync/livesync-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,10 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi

const startSyncFilesTimeout = (platform?: string) => {
timeoutTimer = setTimeout(async () => {
if (platform && liveSyncData.bundle) {
filesToSync = filesToSyncMap[platform];
}

if (filesToSync.length || filesToRemove.length) {
const currentFilesToSync = _.cloneDeep(filesToSync);
filesToSync.splice(0, filesToSync.length);
Expand Down Expand Up @@ -732,9 +736,7 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi
filesToRemove,
startSyncFilesTimeout: async (platform: string) => {
if (platform) {
filesToSync = filesToSyncMap[platform];
await startSyncFilesTimeout();
filesToSyncMap[platform] = [];
await startSyncFilesTimeout(platform);
} else {
// This code is added for backwards compatibility with old versions of nativescript-dev-webpack plugin.
await startSyncFilesTimeout();
Expand Down