fix-next(preview): externalize all plugins from the Preview app #4004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The external plugins that depend on Angular or Vue won't work if the corresponding dependency is bundled. The plugin will look for these dependencies only in the external `tns_modules`. That's why Angular and Vue should be external and not bundled by webpack.
Mark all plugins that are already in the Preview app as external. This will prevent webpack from bundling them. Having two instances of one plugin, may cause problems.
sis0k0
force-pushed
the
sis0k0/preview-externalize-angular
branch
from
326cebc to
aae5ace
Compare
DimitarTachev
approved these changes
Oct 10, 2018
sis0k0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark all plugins that are already in the Preview app as external. This
will prevent webpack from bundling them. Having two instances of one
plugin, may cause problems.