Skip to content

fix: increase timeout for establishing LS socket connection. #4003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

KristianDD
Copy link
Contributor

PR Checklist

What is the current behavior?

Sometimes with big applications the assets unpacking step in android runtime takes too long and the LS socket connection fails, despite the application process being already started.

What is the new behavior?

The runtime has two times more time to unpack the assets, before CLI stops to attempt to connect and throws an error.

Fixes #3818

@KristianDD KristianDD merged commit ac547fd into master Oct 10, 2018
@KristianDD KristianDD deleted the kddimitrov/increase-socket-connection-timeout branch October 10, 2018 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants