Skip to content

fix: show more descriptive message when tns preview -hmr command is executed and the project has webpack plugin with version lower than 0.17.0 #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Oct 5, 2018

When the user executes tns preview --hmr and the project is with nativescript-dev-webpack version lower than 0.17.0, {N} CLI does not show descriptive message. We should to notify the user to ensure webpack.config.js file is properly updated after updating nativescript-dev-webpack.

PR Checklist

… executed and the project has webpack plugin with version lower than 0.17.0
@Fatme Fatme merged commit a8df3e7 into master Oct 6, 2018
@Fatme Fatme deleted the fatme/update-not-supported-webpack-msg branch October 6, 2018 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants