Kddimitrov/restart on hmr fail #3980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianDD
force-pushed
the
kddimitrov/restart-on-hmr-fail
branch
2 times, most recently
from
99642ab to
2e7bc0a
Compare
DimitarTachev
approved these changes
Oct 5, 2018
| @@ -0,0 +1,4 @@ | |||
| interface IHmrStatusService { | |||
| awaitHmrStatus(deviceId: string, operationHash: string): Promise<number>; | |||
There was a problem hiding this comment.
awaitHmrStatus -> getHmrStatus
lib/services/hmr-status-service.ts
Outdated
| const interval = setInterval(() => { | ||
| const status = this.getStatusByKey(key); | ||
| if (status || retryCount === 0) { | ||
| clearInterval(interval); |
|
|
||
| if (data.appFilesUpdaterOptions.useHotModuleReload && currentHmrData.hash) { | ||
| const devices = _.filter(this.$previewSdkService.connectedDevices, { platform: platform.toLowerCase() }); | ||
| _.forEach(devices, async (previewDevice: Device) => { |
lib/services/log-parser-service.ts
Outdated
| } | ||
|
|
||
| private processDeviceLogResponse(message: string, deviceIdentifier: string) { | ||
| const device = this.$devicesService.getDeviceByIdentifier(deviceIdentifier); | ||
| const devicePlatform = device.deviceInfo.platform.toLowerCase(); | ||
| const devicePlatform = this.tryGetPlatform(deviceIdentifier); |
There was a problem hiding this comment.
check the performance implications here (we will get the device or catch an exception for each log)
Fatme
reviewed
Oct 8, 2018
| const status = await this.$hmrStatusService.awaitHmrStatus(previewDevice.id, currentHmrData.hash); | ||
| if (status === HmrConstants.HMR_ERROR_STATUS) { | ||
| await this.applyChanges(platformData, projectData, currentHmrData.fallbackFiles[platform], false); | ||
| } |
There was a problem hiding this comment.
boolean variable passed as argument 🙀 🙀 🙀
await this.applyChanges(platformData, projectData, currentHmrData.fallbackFiles[platform], { useHotModuleReload: false });
a8f42a5 to
0c5b380
Compare
DimitarTachev
approved these changes
Oct 8, 2018
KristianDD
force-pushed
the
kddimitrov/restart-on-hmr-fail
branch
from
0c5b380 to
4e94cb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When HMR fails to apply patch the application will remain with old content.
What is the new behavior?
When HMR fails to apply patch the application gets updated by regular LS and restarted.
Fixes/Implements/Closes #3892.