Skip to content

fix: replace %s with deviceIdentifier on debug command #3979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Oct 5, 2018

PR Checklist

What is the current behavior?

"Successfully transferred all files on device %s" message is shown on tns debug ios --debug-brk command on iOS simulator

What is the new behavior?

"Successfully transferred all files on device FEE9701C-B925-4AF9-BCEC-862BEE21B4BA" message is shown on tns debug ios --debug-brk command on iOS simulator

Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first file (from common) is not used really.

@Fatme Fatme merged commit b6d6063 into master Oct 6, 2018
@Fatme Fatme deleted the fatme/fix-missing-placeholder branch October 6, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants