Skip to content

fix: don't show warnings for non-nativescript plugins on tns preview --bundle command #3958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Oct 1, 2018

PR Checklist

What is the current behavior?

Warning is shown for non nativescript plugins on tns preview --bundle command

What is the new behavior?

Warning is not shown for non nativescript plugins on tns preview --bundle command

Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also suggest the users to use Webpack in case they are not using it at the moment and have plugins without native code that are not available in the Preview app.

@Fatme
Copy link
Contributor Author

Fatme commented Oct 2, 2018

run ci

@Fatme Fatme merged commit c51da02 into master Oct 2, 2018
@Fatme Fatme deleted the fatme/preview-js-plugin-warnings branch October 2, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants